[PM-10996] Remove restrict-provider-access feature flag #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
3 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
359
to
363
| return true; | ||
| } | ||
|
|
||
| // Provider users can only access organization ciphers if RestrictProviderAccess is disabled | ||
| if (await _currentContext.ProviderUserForOrgAsync(organizationId)) | ||
| { | ||
| return !_featureService.IsEnabled(FeatureFlagKeys.RestrictProviderAccess); | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
logic: Verify that removing this check doesn't inadvertently allow provider users to access organization ciphers when they shouldn't
Comment on lines
376
to
380
| return true; | ||
| } | ||
|
|
||
| // Provider users can only access all ciphers if RestrictProviderAccess is disabled | ||
| if (await _currentContext.ProviderUserForOrgAsync(organizationId)) | ||
| { | ||
| return !_featureService.IsEnabled(FeatureFlagKeys.RestrictProviderAccess); | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
logic: Confirm that removing this condition doesn't unintentionally grant access to unassigned ciphers for provider users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎟️ Tracking
PM-10996 Remove restrict-provider-access feature flag
PM-12055
📔 Objective
Remove the restrict-provider-access feature flag and any references.
Important
This should only be merged after the corresponding Clients PR has been fully released to all clients.
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request removes the 'restrict-provider-access' feature flag, simplifying authorization logic for provider users in the CiphersController and updating related tests.
src/Core/Constants.cssrc/Api/Vault/Controllers/CiphersController.csto remove feature flag checkstest/Api.Test/Vault/Controllers/CiphersControllerTests.csto ensure providers cannot edit ciphers as admins