[PM-10703] Admin Portal Selecting Families plan does not check defau… #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ies-plan-does-not-check-default-features
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
2 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
+242
to
+243
| TempData["Error"] = "Plan does not support Secrets Manager"; | ||
| return RedirectToAction("Edit", new { id }); |
There was a problem hiding this comment.
style: Consider using a constant or enum for the error message to maintain consistency and ease of maintenance.
| @@ -181,7 +181,6 @@ public OrganizationEditModel( | |||
| */ | |||
| public object GetPlansHelper() => | |||
| StaticStore.Plans | |||
There was a problem hiding this comment.
logic: Removing this filter may include plans that don't support Secrets Manager. Ensure this doesn't cause issues elsewhere in the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…lt features
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-10703
📔 Objective
Families plan is not checking default features when being selected.
This is happening because the families plan doesn't support secrets manager when a free or paid organization has secrets manager selected. Because it then resolved to an undefined plan, no values are being selected. So we remove the filter in the
OrganizationEditModel.To get the error message to display properly, we store the error message in
TempDataand then redirect to theEditaction.📸 Screenshots
⏰ Reminders before review
🦮 Reviewer guidelines
:+1:) or similar for great changes:memo:) or ℹ️ (:information_source:) for notes or general info:question:) for questions:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion:art:) for suggestions / improvements:x:) or:warning:) for more significant problems or concerns needing attention:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt:pick:) for minor or nitpick changesGreptile Summary
This pull request addresses an issue with the Families plan not correctly checking default features in the Admin Portal, specifically related to Secrets Manager support.
OrganizationsController.csto improve error handling and check for Secrets Manager support before updating organizationsOrganizationEditModel.csto remove a filter inGetPlansHelper, allowing all plans to be included regardless of Secrets Manager supportEditaction methodOrganizationsController.csGetPlansHelperneed careful consideration for overall plan selection and feature management