revert wallet level historical balance call #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This pull request reverts the addition of the listHistoricalBalances method at the wallet level to avoid confusion, as documented in the CHANGELOG.md file under the 'Unreleased' section.
- Removed
listHistoricalBalancesmethod fromWalletclass insrc/coinbase/wallet.ts - Deleted corresponding test suite for
listHistoricalBalancesinsrc/tests/wallet_test.ts - Updated CHANGELOG.md to reflect the reversion under the 'Unreleased' section
- This change may impact code that was using the wallet-level historical balance functionality
3 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings
| @@ -2,6 +2,10 @@ | |||
|
|
|||
| ## Unreleased | |||
|
|
|||
| ### Reverted | |||
|
|
|||
| - Remove `listHistoricalBalances` wallet method to avoid confusion. | |||
There was a problem hiding this comment.
style: Consider adding a brief explanation of why this might cause confusion, e.g., '(historical balances are more accurately tracked at the address level)'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed? Why?
revert wallet level historical balance call to avoid confusion
Qualified Impact