-
Notifications
You must be signed in to change notification settings - Fork 29
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Implement auto-updating from the lovely cookies :)
- Loading branch information
Showing
5 changed files
with
1,934 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
gaffer_updater |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
557d709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woo!
557d709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TheDuckCow in the docs/tutorial you might want to mention adding the update folder to
.gitignore
.Also
#2
in step 7 here does not include theself, context
params in theupdate_notice_box_ui()
call if you just copy-paste from the text (though it is included in the screenshot).557d709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the notice @gregzaal, fixed now. And yeah I'll make a note of that for gitignore, it's a good point.
Also tried testing the updater with your setup, UI all looks good but when trying to revert to 2.5 the updater (rightfully?) returns an error saying e.g. with this release that no
__init__.py
file is found. Seems that was back prior to having the .zip install method since it doesn't have files split up yet - for this reason, I'd just point to making use of the minimum version e.g.updater.version_min_update = (2,6,0)
if 2.6 is the next release you expect to include with the updater itself and carry that forward.557d709
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha, sure thing, thanks for checking :)