-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow calling Draft4Support.Enable() multiple times #11
Allow calling Draft4Support.Enable() multiple times #11
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this is the right direction. Draft4Support.Enable()
is a bootstrapping call. It should only ever be called during application setup.
What's your use case?
We use it in multiple test fixtures that might be executed all at once or separately by filtering -- and initialization is per fixture, not per project. This is also something that worked in Graeae 0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like the idea of setting up production code just to facilitate tests, but I agree that this method should be safe to re-call.
Please add an entry in the RELEASE_NOTES.md file.
("exclusiveMaximum", new [] { "maximum" }), | ||
("exclusiveMinimum", new [] { "minimum" }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unnecessary edit, please.
Co-authored-by: Greg Dennis <[email protected]>
Co-authored-by: Greg Dennis <[email protected]>
Second call to
Draft4Support.Enable()
was throwing