Converted the coffeescript to javascript ahead of time #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Gemfile for Rails 7
|
Sorry it took me so long to get to these PRs. Any reason to keep |
|
Closing as I believe this was accomplished in #166. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was receiving the following error on my main project:
Looking at the library source code I realised that I was still using CoffeeScript and transpiled it to js.
Since Javascript has evolved a lot in the last few years I will simplify this dependency and convert the CoffeeScript directly to js ahead of time in the source code.
I have used https://awsm-tools.com/coffeescript-to-javascript to do the conversion.
I have
git grep require | grep jsthe source code and there is norequirein the generated javascript.