Icons: Make PNG/XPM transparent, hi-res #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extend the ImageMagick `convert` commands for generating icon bitmaps: - Add `-background none`, to render with background transparency. - Add `-density 300x300`, to render larger sizes at full resolution. Because the SVG's internal coordinate system is only sized for 64x64 pixels, ImageMagick will render at that size and then scale the _bitmap_ up, when outputting larger image sizes. Increasing the DPI using `-density` allows it to upscale the SVG vectors at full resolution. Signed-off-by: FeRD (Frank Dana) <[email protected]>
|
(Yes, the need to specify either/both of these explicitly ranks among the more stupid and inexplicable of ImageMagick's... "endearing quirks".) |
Output the icon bitmap images at standard 96 DPI, not the 300 DPI we temporarily scaled the coordinate system to when rasterizing the SVG. Signed-off-by: FeRD (Frank Dana) <[email protected]>
|
I added an additional |
|
@gregkh Ping? I'm sure usbview is relatively low-priority, and there's certainly no real urgency to this. Just wanted to call your attention to it, if you hadn't seen. Thanks! |
|
On Fri, May 24, 2024 at 03:17:47AM -0700, Frank Dana wrote:
@gregkh Ping? I'm sure usbview is relatively low-priority, and there's certainly no real urgency to this. Just wanted to call your attention to it, if you hadn't seen. Thanks!
I see it, thanks, will be a few weeks before I get back to usbview
changes!
greg k-h
|
|
Weird... I had a new notification for this PR, but I can't for the life of me figure out why. Nothing's changed, that I can see. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the ImageMagick
convertcommands for generating icon bitmaps:-background none, to render with background transparency.-density 300x300, to render larger sizes at full resolution.Because the SVG's internal coordinate system is only sized for 64x64 pixels, ImageMagick will render at that size and then scale the bitmap up, when outputting larger image sizes. Increasing the DPI using
-densityallows it to upscale the SVG vectors at full resolution.Comparison: 256x256
usbview.pngfrom this branch vs.master, atop solid red