Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating how ADAGE weights are saved #93

Merged
merged 3 commits into from
Oct 10, 2017

Conversation

gwaybio
Copy link
Collaborator

@gwaybio gwaybio commented Oct 10, 2017

partially addresses #85 - updates how and where ADAGE gene weights are saved

@gwaybio gwaybio requested a review from jaclyn-taroni October 10, 2017 15:01
Copy link

@jaclyn-taroni jaclyn-taroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Provided I am correctly understanding the changes to how the weights are being saved (see my single comment), I approve

weight_file = os.path.join('results', 'adage_gene_weights.tsv')

weight_matrix = pd.DataFrame(autoencoder.get_weights()[0], index=rnaseq_df.columns,
columns=range(1, 101)).T

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming this is just a move away from zero-based indexing?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

correct - to maintain consistency...for now. I intend to update all of these at a later date (as per #86)

@gwaybio gwaybio merged commit 4bb7c5c into greenelab:master Oct 10, 2017
@gwaybio gwaybio deleted the fix-adage-weight-bug branch October 10, 2017 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants