-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding Authors for Methylation Section #995
Conversation
Planning on adding two more sections that expand on the points of the last paragraph. Will need help editing these points and making text more concise, to leave room for remaining two paragraphs. Also looking to adjust some text from the previous gene expression paragraphs and text surrounding latent space prediction.
Pulling recent changes from greenelab
Co-Authored-By: Casey Greene <[email protected]>
Co-Authored-By: Casey Greene <[email protected]>
AppVeyor build 1.0.46 for commit ebf0e55 by @jlevy44 is now complete. The rendered manuscript from this build is temporarily available for download at: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple things I noticed. Need Brock and Alexander to confirm that they approve as well plus give any relevant COIs or confirm none.
I approve, and have no conflicts.
The funding information provided did not appear to populate in the draft build.
Thanks
From: Casey Greene <[email protected]>
Reply-To: greenelab/deep-review <[email protected]>
Date: Thursday, March 5, 2020 at 6:37 AM
To: greenelab/deep-review <[email protected]>
Cc: "Brock C. Christensen" <[email protected]>, Mention <[email protected]>
Subject: Re: [greenelab/deep-review] Adding Authors for Methylation Sectioon (#995)
@cgreene commented on this pull request.
A couple things I noticed. Need Brock and Alexander to confirm that they approve as well plus give any relevant COIs or confirm none.
________________________________
In content/metadata.yaml<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgreenelab%2Fdeep-review%2Fpull%2F995%23discussion_r388238865&data=02%7C01%7CBrock.C.Christensen%40dartmouth.edu%7C7a1bcb62b53e4025cb9008d7c0f99f30%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637190050657550595&sdata=fIn%2Fge0Z8Xx2FQubaHo2oymZcMNs2kp1RnCPJDWFOmg%3D&reserved=0>:
@@ -70,6 +70,39 @@ authors:
coi:
string: "None"
lastapproved: !!str 2017-05-26
+ - github: jlevy44
+ name: Joshua J. Levy
+ orcid: 0000-0001-8050-1291
+ email: [email protected]
+ affiliations:
+ - Program in Quantitative Biomedical Sciences, Geisel School of Medicine at Dartmouth, Lebanon, NH
+ funders: Burroughs Wellcome Fund Big Data in the Life Sciences training grant at Dartmouth
+ v1: "Drafted one or more subsections"
+ v2: ""
+ coi:
+ string: "None"
Can you also add a last approved date? See the other entries. Can make it today.
________________________________
In content/metadata.yaml<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgreenelab%2Fdeep-review%2Fpull%2F995%23discussion_r388239148&data=02%7C01%7CBrock.C.Christensen%40dartmouth.edu%7C7a1bcb62b53e4025cb9008d7c0f99f30%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637190050657560591&sdata=fiQZ1dLl3ZStiThA%2BrKd9rbv91N5iZZorqZKMJLWhxA%3D&reserved=0>:
@@ -70,6 +70,39 @@ authors:
coi:
string: "None"
lastapproved: !!str 2017-05-26
+ - github: jlevy44
+ name: Joshua J. Levy
+ orcid: 0000-0001-8050-1291
+ email: [email protected]
+ affiliations:
+ - Program in Quantitative Biomedical Sciences, Geisel School of Medicine at Dartmouth, Lebanon, NH
+ funders: Burroughs Wellcome Fund Big Data in the Life Sciences training grant at Dartmouth
+ v1: "Drafted one or more subsections"
Can you switch these from v1 which should be an empty string to v2?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgreenelab%2Fdeep-review%2Fpull%2F995%3Femail_source%3Dnotifications%26email_token%3DAFJQHMU5VSQAXI4GBDXV2STRF6FIRA5CNFSM4LBSJME2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCYDBJUA%23pullrequestreview-369497296&data=02%7C01%7CBrock.C.Christensen%40dartmouth.edu%7C7a1bcb62b53e4025cb9008d7c0f99f30%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637190050657570584&sdata=FOEHa2FQyFSt5dA%2FxZ0KXdD%2B6dvISbrt2%2BswO%2B3Uy%2Fo%3D&reserved=0>, or unsubscribe<https://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAFJQHMVFCFRTLDKKC3TFAUDRF6FIRANCNFSM4LBSJMEQ&data=02%7C01%7CBrock.C.Christensen%40dartmouth.edu%7C7a1bcb62b53e4025cb9008d7c0f99f30%7C995b093648d640e5a31ebf689ec9446f%7C0%7C0%7C637190050657570584&sdata=PAwUHsMqtnSSXnJUL22QxbqpSdWRnLaqX4WJ9OcINJY%3D&reserved=0>.
|
@brockclarke funding is not yet automated. I can try to do that on a future PR. Thanks for noting that! I've created #996 to address this. |
AppVeyor build 1.0.48 for commit 58adbfc by @jlevy44 is now complete. The rendered manuscript from this build is temporarily available for download at: |
AppVeyor build 1.0.49 for commit 91f684e by @jlevy44 is now complete. The rendered manuscript from this build is temporarily available for download at: |
content/metadata.yaml
Outdated
- github: AlexanderTitus | ||
name: Alexander J. Titus | ||
orcid: 0000-0002-0145-9564 | ||
email: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jlevy44 can you please update my email to [email protected].
After that, I approve the update, and confirm that I have COI is "none".
Thanks all.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
AppVeyor build 1.0.52 for commit 992f01c by @jlevy44 is now complete. The rendered manuscript from this build is temporarily available for download at: |
Assuming this build passes (so, if I didn't botch something) I'll get this merged in! |
AppVeyor build 1.0.53 for commit 9198ad0 by @cgreene is now complete. The rendered manuscript from this build is temporarily available for download at: |
Woo! Congrats 🎊 - welcome to the team and author list for v2.0 :) |
[ci skip] This build is based on 03b2cd2. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/03b2cd2bb41d1545f0bec28a57d1c1ac18bdafd4/checks https://github.com/greenelab/deep-review/runs/52391323
[ci skip] This build is based on 03b2cd2. This commit was created by the following CI build and job: https://github.com/greenelab/deep-review/commit/03b2cd2bb41d1545f0bec28a57d1c1ac18bdafd4/checks https://github.com/greenelab/deep-review/runs/52391323
Hi there!
Just adding our author information.
Please, @AlexanderTitus and @brockclarke can you verify that these details are correct? Thanks!