Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pointer to CDC #76

Merged
merged 2 commits into from
Mar 26, 2020
Merged

Add pointer to CDC #76

merged 2 commits into from
Mar 26, 2020

Conversation

cgreene
Copy link
Member

@cgreene cgreene commented Mar 26, 2020

This sort of closes #53. It adds a note, outlined in red, that this document is not intended for the general public. I pointed folks towards the CDC and mentioned others who may have useful information. What do folks think of this? Especially people who weighed in on #53.

@rhagenson
Copy link
Collaborator

This reads well to me.

I thought Manubot had test rendering in PRs, is that not the case (any longer)?

@cgreene
Copy link
Member Author

cgreene commented Mar 26, 2020

@rhagenson : This reminds me! I need to address #31! Let me do that and get you to test things out to see how my documentation works 😁

@rhagenson
Copy link
Collaborator

@cgreene Sounds good to me. I will keep an eye out for the #31 fix.

Copy link
Collaborator

@dhimmel dhimmel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good syntactically

image

@dhimmel
Copy link
Collaborator

dhimmel commented Mar 26, 2020

I thought Manubot had test rendering in PRs, is that not the case (any longer)?

It does, it's just a bit hidden with the new GitHub Actions interface. See far right of screenshot:

image

We're working on notification comments with this link.

content/00.front-matter.md Outdated Show resolved Hide resolved
@cgreene
Copy link
Member Author

cgreene commented Mar 26, 2020

I filed #79. @rhagenson, can you take a look at that one and see if it's helpful?

@cgreene cgreene merged commit cba28f2 into greenelab:master Mar 26, 2020
@cgreene cgreene deleted the public-header branch March 26, 2020 16:19
@rando2 rando2 mentioned this pull request Jun 30, 2020
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Public versus Academic Balance
4 participants