Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert where to contribute section and links #23

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Insert where to contribute section and links #23

merged 2 commits into from
Mar 24, 2020

Conversation

mprobson
Copy link
Collaborator

Using pandoc style syntax.

@mprobson
Insert where to contribute section and links
3cffe42 
Change-Id: I504d7d42184c06e0d7103e3034e1a9f5558b0b2a
@mprobson mprobson mentioned this pull request Mar 23, 2020
Closed
@rando2
Copy link
Collaborator

rando2 commented Mar 23, 2020

Did you mean to put this in the abstract or in the readme? I may be behind the times but wanted to check!

@mprobson
Copy link
Collaborator Author

My understanding was to put it in the paper so people who are linked directly to it can find there way to contribute. I can't figure out how to check the generated paper to see if this worked though. You can see the chat in #19 to confirm I understood correctly. Please let me know if I misunderstood and I'm happy to alter this PR!

@cgreene
Copy link
Member

cgreene commented Mar 23, 2020

@mprobson : to check the outputs:

  1. Click Show All Checks
    Screen Shot 2020-03-23 at 4 19 39 PM
  2. Click Details
    Screen Shot 2020-03-23 at 4 19 44 PM
  3. Click Artifacts
    Screen Shot 2020-03-23 at 4 19 59 PM

Hope this helps :) Looks like it did show up!

@agitter
Copy link
Collaborator

agitter commented Mar 23, 2020

@cgreene since we don't have AppVeyor notifications linking directly to artifacts and GitHub Actions comments are still being explored (manubot/rootstock#322), we should stick your screenshots and instructions above somewhere permanent. They'll be very helpful for pull request reviewers.

agitter
agitter reviewed Mar 23, 2020
View reviewed changes
content/01.abstract.md Outdated Show resolved Hide resolved
@mprobson
Copy link
Collaborator Author

@cgreene Thanks, I totally missed the Artifacts drop down 🤦‍♂ I'm happy with the changes if y'all are but I can update / tweak things as required / necessary.

@mprobson
Copy link
Collaborator Author

@cgreene since we don't have AppVeyor notifications linking directly to artifacts and GitHub Actions comments are still being explored (manubot/rootstock#322), we should stick your screenshots and instructions above somewhere permanent. They'll be very helpful for pull request reviewers.

Do we have / want a Wiki for this?

@mprobson
Change contribution links from pandoc to markdown style
6d94154 
Change-Id: I64e2b7d21238ed4b29ff6de25bc8b00f5ba082b9
@rando2 rando2 mentioned this pull request Mar 24, 2020
Closed
@rando2
Copy link
Collaborator

rando2 commented Mar 24, 2020

I pulled the wiki question into #31 because there is some other content we may want to put screenshots up for. I wanted to check if @agitter has the right permissions to approve and merge? (I am unable to see what permissions you have on this repo!)

cgreene
cgreene approved these changes Mar 24, 2020
View reviewed changes
Copy link
Member

@cgreene cgreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@cgreene
Copy link
Member

cgreene commented Mar 24, 2020

I'm going to go ahead and merge this one so that folks who show up on the manuscript know where to contribute. Thank you for this contribution!

@cgreene cgreene merged commit aec9ec1 into greenelab:master Mar 24, 2020
github-actions bot pushed a commit that referenced this pull request Mar 24, 2020
@cgreene
Merge pull request #23 from mprobson/contribution-section
ace0d7d 
[ci skip]

This build is based on
aec9ec1.

This commit was created by the following CI build and job:
https://github.com/greenelab/covid19-review/commit/aec9ec12a7ab5bb642f3f47352043b863583571f/checks
https://github.com/greenelab/covid19-review/runs/62146598
github-actions bot pushed a commit that referenced this pull request Mar 24, 2020
@cgreene
Merge pull request #23 from mprobson/contribution-section
c619479 
[ci skip]

This build is based on
aec9ec1.

This commit was created by the following CI build and job:
https://github.com/greenelab/covid19-review/commit/aec9ec12a7ab5bb642f3f47352043b863583571f/checks
https://github.com/greenelab/covid19-review/runs/62146598
@agitter
Copy link
Collaborator

agitter commented Mar 24, 2020

I wanted to check if @agitter has the right permissions to approve and merge?

I believe anyone can review and indicate that they approve of a pull request regardless of their permissions. I don't have write permission on this repo so I can't merge.

@mprobson mprobson deleted the contribution-section branch March 27, 2020 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agitter agitter agitter left review comments

@cgreene cgreene cgreene approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mprobson @rando2 @cgreene @agitter