Change: use vars.greenbone_registry not secrets.greenbone_registry (#124

)
greenbone · Oct 25, 2024 · 0787c2c · 0787c2c
1 parent ffe5bf9
commit 0787c2c
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 10 deletions.
diff --git a/.github/workflows/container-build-push-2nd-gen.yml b/.github/workflows/container-build-push-2nd-gen.yml
@@ -124,7 +124,7 @@ jobs:
           image-tags: raw,value=${{ inputs.ref-name || github.ref_name }}-amd64 # temporary tag that will be overwritten with the manifest upload
           image-platforms: linux/amd64
           image-flavor: latest=false
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
           scout-user: ${{ secrets.DOCKERHUB_USERNAME }}
@@ -177,7 +177,7 @@ jobs:
           image-tags: raw,value=${{ inputs.ref-name || github.ref_name }}-arm64 # temporary tag that will be overwritten with the manifest upload
           image-platforms: linux/arm64
           image-flavor: latest=false
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
           scout-user: ${{ secrets.DOCKERHUB_USERNAME }}
@@ -209,7 +209,7 @@ jobs:
         id: meta
         uses: docker/metadata-action@8e5442c4ef9f78752691e2d8f8d19755c6f78e81 # v5.5.1
         with:
-          images: ${{ secrets.GREENBONE_REGISTRY }}/${{ inputs.image-url }}
+          images: ${{ vars.GREENBONE_REGISTRY }}/${{ inputs.image-url }}
           flavor: latest=false
           tags: |
             type=raw,value=latest,enable=${{ (needs.build-amd64.outputs.is-latest-tag == 'true') && (inputs.base-image-label == 'stable') }}
@@ -243,7 +243,7 @@ jobs:
             ${{ needs.build-amd64.outputs.digest }}
             ${{ needs.build-arm64.outputs.digest }}
           url: ${{ inputs.image-url }}
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
 

diff --git a/.github/workflows/container-build-push-feed.yml b/.github/workflows/container-build-push-feed.yml
@@ -106,7 +106,7 @@ jobs:
           image-tags: raw,value=${{ inputs.ref-name || github.ref_name }}-amd64 # temporary tag that will be overwritten with the manifest upload
           image-platforms: linux/amd64
           image-flavor: latest=false
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
 
@@ -148,7 +148,7 @@ jobs:
           image-tags: raw,value=${{ inputs.ref-name || github.ref_name }}-arm64 # temporary tag that will be overwritten with the manifest upload
           image-platforms: linux/arm64
           image-flavor: latest=false
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
 
@@ -163,7 +163,7 @@ jobs:
         id: meta
         uses: docker/metadata-action@8e5442c4ef9f78752691e2d8f8d19755c6f78e81 # v5.5.1
         with:
-          images: ${{ secrets.GREENBONE_REGISTRY }}/${{ inputs.image-url }}
+          images: ${{ vars.GREENBONE_REGISTRY }}/${{ inputs.image-url }}
           tags: ${{ inputs.image-tags }}
 
       - name: Create multi arch manifest
@@ -180,7 +180,7 @@ jobs:
             ${{ needs.build-amd64.outputs.digest }}
             ${{ needs.build-arm64.outputs.digest }}
           url: ${{ inputs.image-url }}
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
 

diff --git a/.github/workflows/helm-container-build-push-3rd-gen.yml b/.github/workflows/helm-container-build-push-3rd-gen.yml
@@ -197,7 +197,7 @@ jobs:
             type=ref,event=pr
             # use unstable for main branch
             type=raw,value=unstable,enable={{is_default_branch}}
-          registry: ${{ secrets.GREENBONE_REGISTRY }}
+          registry: ${{ vars.GREENBONE_REGISTRY }}
           registry-username: ${{ secrets.GREENBONE_REGISTRY_USER }}
           registry-password: ${{ secrets.GREENBONE_REGISTRY_TOKEN }}
 
@@ -252,7 +252,7 @@ jobs:
       - building-service-chart
       - building-product-chart
       - building-product-compose
-    if: ${{ !cancelled()  && startsWith(inputs.notify, 'true') }}
+    if: ${{ !cancelled() && startsWith(github.ref, 'refs/tags/v') && startsWith(inputs.notify, 'true') }}
     uses: greenbone/workflows/.github/workflows/notify-mattermost-3rd-gen.yml@main
     with:
       status: ${{ contains(needs.*.result, 'failure') && 'failure' || 'success' }}