Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change: Extend invalid URL plugin and relevant tests. #764

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

cfi-gb
Copy link
Member

@cfi-gb cfi-gb commented Oct 24, 2024

What

  • Adds more cases which should be detected which seems to be not covered by the validators package (yet)
  • Excludes a few additional valid / allowed URLs which are now reported as invalid after the version bump of the validators package in Change: Update validators and disable strict_query #763

Why

  • To catch additional possible malformed URLs introduced by e.g. some automatic extraction or by copy'n'paste like seen / noticed in:
    • greenbone/vulnerability-tests#13985
    • greenbone/vulnerability-tests#13986
    • greenbone/vulnerability-tests#13953
    • greenbone/vulnerability-tests#13959
    • greenbone/vulnerability-tests#14055
  • To exclude a few special URLs which seems to be valid but edge cases and reported as invalid by the validators package

References

None

Checklist

  • Tests

@cfi-gb cfi-gb self-assigned this Oct 24, 2024
Copy link

github-actions bot commented Oct 24, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 2c2003f.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 24, 2024

Conventional Commits Report

Type Number
Changed 2

🚀 Conventional commits found.

@cfi-gb cfi-gb force-pushed the extend_xref_plugin branch 4 times, most recently from 2a0b081 to 0de9da4 Compare October 24, 2024 13:27
Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.69%. Comparing base (ec6ca34) to head (2c2003f).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #764      +/-   ##
==========================================
+ Coverage   79.53%   79.69%   +0.15%     
==========================================
  Files          87       87              
  Lines        2986     3009      +23     
  Branches      577      584       +7     
==========================================
+ Hits         2375     2398      +23     
  Misses        462      462              
  Partials      149      149              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cfi-gb cfi-gb removed their assignment Oct 24, 2024
@cfi-gb cfi-gb marked this pull request as ready for review October 24, 2024 13:30
@cfi-gb cfi-gb requested a review from a team as a code owner October 24, 2024 13:30
@cfi-gb
Copy link
Member Author

cfi-gb commented Oct 24, 2024

@greenbone/troubadix-maintainers Ready for a first review and (improvement) suggestions always welcome.

@cfi-gb cfi-gb force-pushed the extend_xref_plugin branch 2 times, most recently from c7af1b2 to 5fc48a1 Compare October 24, 2024 13:52
troubadix/plugins/script_xref_url.py Outdated Show resolved Hide resolved
@cfi-gb cfi-gb force-pushed the extend_xref_plugin branch 2 times, most recently from bbb029c to 306a571 Compare October 25, 2024 09:23
@cfi-gb cfi-gb requested review from a team and n-thumann October 25, 2024 09:24
@cfi-gb cfi-gb added the make release To trigger GitHub release action label Oct 25, 2024
@n-thumann n-thumann merged commit 10a852a into main Oct 28, 2024
13 checks passed
@n-thumann n-thumann deleted the extend_xref_plugin branch October 28, 2024 07:14
@n-thumann
Copy link
Member

n-thumann commented Oct 28, 2024

Forgot to mention this in the review: I ran this plugin against common/gsf/2024 and there were five errors reported: Four of them newly added by this change and the remaining one caused by a bug in validators (caused by trailing # in the URL fragment, fixed by python-validators/validators#405).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants