Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: standalone plugin for deprecating VTs #718

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Add: standalone plugin for deprecating VTs #718

merged 5 commits into from
Jul 5, 2024

Conversation

amy-gb
Copy link
Contributor

@amy-gb amy-gb commented Jun 19, 2024

What

Add a standalone plugin to deprecate VTs. The script takes either a single file or a directory of files, and writes the updated file to a new location.

The changes the script should accomplish are (from the relevant internal Confluence page):

  1. add a note to the summary of why the VT is deprecated
  2. remove all code after the description block
  3. add the early exit (66) to the end
  4. add the deprecated=True tag
  5. remove unneeded script tags

Why

For the Red Hat deployment we need to deprecate hundreds of VTs. Therefore it makes sense to have a script that does this

References

VTA-531

Checklist

  • Tests

@amy-gb amy-gb requested a review from a team as a code owner June 19, 2024 08:24
Copy link

github-actions bot commented Jun 19, 2024

Conventional Commits Report

Type Number
Added 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 79.31034% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.45%. Comparing base (6613c5b) to head (139fb8e).
Report is 1 commits behind head on main.

Files Patch % Lines
troubadix/standalone_plugins/deprecate_vts.py 79.31% 11 Missing and 7 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #718      +/-   ##
==========================================
- Coverage   79.45%   79.45%   -0.01%     
==========================================
  Files          85       86       +1     
  Lines        2823     2910      +87     
  Branches      596      611      +15     
==========================================
+ Hits         2243     2312      +69     
- Misses        440      451      +11     
- Partials      140      147       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@amy-gb amy-gb force-pushed the VTA-531 branch 3 times, most recently from 19ebde2 to 3d517f3 Compare June 19, 2024 10:01
@cfi-gb
Copy link
Member

cfi-gb commented Jun 21, 2024

Note: I have redacted an internal link from the description.

troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
@amy-gb amy-gb requested a review from a team as a code owner July 1, 2024 10:12
@amy-gb amy-gb force-pushed the VTA-531 branch 3 times, most recently from 47036da to 7c11f18 Compare July 1, 2024 12:28
@amy-gb
Copy link
Contributor Author

amy-gb commented Jul 1, 2024

Thank you for the thorough review @mbrinkhoff! I believe I have addressed all of your comments.

@mbrinkhoff
Copy link
Member

Thank you for the thorough review @mbrinkhoff! I believe I have addressed all of your comments.

I will take another look

troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Show resolved Hide resolved
troubadix/standalone_plugins/deprecate_vts.py Outdated Show resolved Hide resolved
@amy-gb amy-gb force-pushed the VTA-531 branch 2 times, most recently from 2136d19 to dea16c6 Compare July 4, 2024 08:07
@n-thumann n-thumann enabled auto-merge July 5, 2024 13:16
@n-thumann n-thumann added the make release To trigger GitHub release action label Jul 5, 2024
@n-thumann n-thumann dismissed mbrinkhoff’s stale review July 5, 2024 13:17

His remark has been addressed

@n-thumann n-thumann merged commit b99e8a2 into main Jul 5, 2024
12 of 13 checks passed
@n-thumann n-thumann deleted the VTA-531 branch July 5, 2024 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
make release To trigger GitHub release action
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants