Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: filtering error on first render for create display #4200

Conversation

daniele-mng
Copy link
Contributor

@daniele-mng daniele-mng commented Nov 5, 2024

##What

Updated the usePageFilter hook. Introduced useRef and useState to manage the returnedFilter to avoid directly modifying the redux store.

##Why

  • Redux error in the charts on first render when resetting the filter to default.
  • Error example
    Screenshot from 2024-11-05 18-02-58

References

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner November 5, 2024 17:05
Copy link

github-actions bot commented Nov 5, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 304fa57.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Files

Copy link

github-actions bot commented Nov 5, 2024

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@daniele-mng daniele-mng force-pushed the fix/filter-cause-error-in-create-display-on-first-render branch from 8696771 to e0da414 Compare November 6, 2024 09:57
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.68%. Comparing base (4058a79) to head (304fa57).
Report is 2 commits behind head on opensight-ui.

Additional details and impacted files
@@              Coverage Diff              @@
##           opensight-ui    #4200   +/-   ##
=============================================
  Coverage         62.67%   62.68%           
=============================================
  Files              1111     1111           
  Lines             98807    98824   +17     
  Branches           6497     6500    +3     
=============================================
+ Hits              61931    61948   +17     
  Misses            36745    36745           
  Partials            131      131           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniele-mng daniele-mng force-pushed the fix/filter-cause-error-in-create-display-on-first-render branch from e0da414 to f95e011 Compare November 8, 2024 08:48
@daniele-mng daniele-mng force-pushed the fix/filter-cause-error-in-create-display-on-first-render branch from f95e011 to 304fa57 Compare November 8, 2024 09:09
@daniele-mng daniele-mng merged commit df141ba into opensight-ui Nov 12, 2024
10 checks passed
@daniele-mng daniele-mng deleted the fix/filter-cause-error-in-create-display-on-first-render branch November 12, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants