Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add loading state to handle authentication status check #4182

Conversation

daniele-mng
Copy link
Contributor

What

This PR adds a loading state to the routes.jsx component to handle the scenario where the authentication status isLoggedIn is not immediately available.

Why

These changes are necessary to prevent the application from incorrectly redirecting to the logged-out routes when the authentication status is not yet determined.

References

GEA-708

Checklist

  • Tests

@daniele-mng daniele-mng requested a review from a team as a code owner October 8, 2024 08:38
Copy link

github-actions bot commented Oct 8, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Snapshot Warnings

⚠️: No snapshots were found for the head SHA 5fabb0a.
Ensure that dependencies are being submitted on PR branches and consider enabling retry-on-snapshot-warnings. See the documentation for more information and troubleshooting advice.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

Copy link

github-actions bot commented Oct 8, 2024

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 64.39%. Comparing base (48a2292) to head (5fabb0a).
Report is 2 commits behind head on opensight-ui.

Files with missing lines Patch % Lines
src/web/routes.jsx 0.00% 11 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           opensight-ui    #4182      +/-   ##
================================================
- Coverage         64.40%   64.39%   -0.01%     
================================================
  Files              1111     1111              
  Lines            103652   103662      +10     
  Branches           6466     6466              
================================================
  Hits              66755    66755              
- Misses            36757    36767      +10     
  Partials            140      140              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniele-mng daniele-mng merged commit a0de56d into opensight-ui Oct 9, 2024
8 of 10 checks passed
@daniele-mng daniele-mng deleted the fix-add-loading-state-to-handle-authentication-status-check branch October 9, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants