Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Show CVSS value "10.0" correctly in charts #3832

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

timopollmeier
Copy link
Member

What

The value "10.0" is now shown instead of the invalid range "10.0 - 10.9" in the charts, e.g. in the bar tooltip of "Results by CVSS".

Why

CVSS scores above 10.0 are not valid.

References

GEA-265

@github-actions
Copy link

github-actions bot commented Aug 8, 2023

Conventional Commits Report

Type Number
Bug Fixes 1

🚀 Conventional commits found.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #3832 (831d79e) into main (911c722) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #3832   +/-   ##
=======================================
  Coverage   60.09%   60.09%           
=======================================
  Files        1023     1023           
  Lines       25148    25151    +3     
  Branches     7433     7434    +1     
=======================================
+ Hits        15112    15115    +3     
  Misses       9094     9094           
  Partials      942      942           
Files Changed Coverage Δ
...components/dashboard/display/cvss/cvsstransform.js 78.26% <100.00%> (+1.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@timopollmeier timopollmeier marked this pull request as ready for review August 8, 2023 08:54
@timopollmeier timopollmeier requested a review from a team as a code owner August 8, 2023 08:54
The value "10.0" is now shown instead of the invalid range
"10.0 - 10.9" in the charts, e.g. in the bar tooltip of
"Results by CVSS".
@bjoernricks bjoernricks merged commit c6ddd97 into main Aug 8, 2023
10 checks passed
@bjoernricks bjoernricks deleted the fix-cvss-tooltips branch August 8, 2023 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants