Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Fixes failing test test_precommit_errors #96

Merged
merged 8 commits into from
Jul 24, 2024

Conversation

Balou9
Copy link
Contributor

@Balou9 Balou9 commented Jul 17, 2024

What

Fix: Fixes failing test test_precommit_errors

Why

tests should be run successfully
https://github.com/greenbone/autohooks-plugin-ruff/actions/runs/9969813302/job/27547480420?pr=94#step:4:32

References

DEVOPS-1111

@Balou9 Balou9 requested a review from a team as a code owner July 17, 2024 10:21
@greenbonebot greenbonebot enabled auto-merge (rebase) July 17, 2024 10:22
Copy link

github-actions bot commented Jul 17, 2024

Conventional Commits Report

Type Number
Added 6
Bug Fixes 1

🚀 Conventional commits found.

Copy link

codecov bot commented Jul 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@d30b9b8). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #96   +/-   ##
=======================================
  Coverage        ?   97.36%           
=======================================
  Files           ?        3           
  Lines           ?      114           
  Branches        ?        0           
=======================================
  Hits            ?      111           
  Misses          ?        3           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Balou9 Balou9 marked this pull request as draft July 17, 2024 10:27
auto-merge was automatically disabled July 17, 2024 10:27

Pull request was converted to draft

@Balou9 Balou9 marked this pull request as ready for review July 19, 2024 09:02
Copy link
Member

@y0urself y0urself left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you try to add a test for the default arguments, or is this "too much" for now?

@Balou9
Copy link
Contributor Author

Balou9 commented Jul 19, 2024

Can you try to add a test for the default arguments, or is this "too much" for now?

Would love to do so, but i don't know how.
What is the behavior we want to check? If using the default argument leads to a successful test and by not using them it fails?

@greenbonebot greenbonebot enabled auto-merge (rebase) July 23, 2024 15:19
@Balou9
Copy link
Contributor Author

Balou9 commented Jul 23, 2024

Can you try to add a test for the default arguments, or is this "too much" for now?

Done!

@greenbonebot greenbonebot merged commit f6c6d44 into main Jul 24, 2024
17 checks passed
@greenbonebot greenbonebot deleted the eowosekun/fix-failed-tests branch July 24, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants