Moving GMT to microjoules #932
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Eco-CI Output:
❌ CO2 Data: |
…esolution to phase_stats
…Reworked transformation of values and units
…ergy; added new tests for SR
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
47 file(s) reviewed, 39 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
45 file(s) reviewed, 15 comment(s)
Edit PR Review Bot Settings | Greptile
There was a problem hiding this comment.
11 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings | Greptile
| case 'centi°C': | ||
| return [transformIfNotNull(value, 100), unit.substr(5)]; | ||
| case 'Hz': | ||
| return [transformIfNotNull(value, 1_000_000_000), `G${unit}`]; |
There was a problem hiding this comment.
logic: Hz conversion adds unit without stripping old unit first - will result in 'GHz' instead of just 'GHz'
Comment on lines
236
to
238
| markline = { | ||
| precision: 4, // generally annoying that precision is by default 2. Wrong AVG if values are smaller than 0.001 and no autoscaling! | ||
| data: [ {type: "average",label: {formatter: "AVG\n(selection):\n{c}"}}] |
There was a problem hiding this comment.
style: Consider using a constant for the precision value of 4 to make it more maintainable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@greptileai
Greptile Summary
This PR implements a significant database schema change and standardization of energy measurements to use microjoules (uJ) instead of millijoules (mJ) across the Green Metrics Tool.
measurement_metricsandmeasurement_valueswith new indexes instructure.sqland migration scriptphase_statstable for improved precision trackingThe changes look technically sound but require careful validation of unit conversions and data migration. The PR improves precision through standardized microjoule measurements while maintaining backward compatibility.