-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MacOS tests on GitHub CI/CD #635
base: main
Are you sure you want to change the base?
Conversation
As a note : In the dev mode branch I implemented a time reduction for the tests. Maybe this helps for this PR? If you review that we can merge that in, or you rebase this PR ontop of the Alternatively you can try our private repository that contains the SSH access to Github runners to start tests and runners interactively with a shell and see how the tests behave |
This is me just playing around. Thank you for the feedback. Next step would be to ssh into the Mac runner and see why things are failing. Will discuss with @dan-mm when he is back. |
I'm back, and I agree with @ribalba. ATM it seems to fail just trying to run the install_mac.sh script, so next step is to just ssh into the runner try it manually. Would have been quite nice if it just worked out of the box, worth the try! :-D |
Note to you both also in the PR: Adding SSH to the PR while it being public in our organization is not secure. Everyone can connect to that session while it is open. Either do this in a forked private repository or lock it down with your public key. Please do not run this in our organizations with also potentially secrets exposed. |
That makes sense. As a side note though, the ssh upterm action fails specifically in the case for macos + limited users (https://github.com/fawazahmed0/action-debug). And github doesn't allow you to make private forks of public repos (for security reasons) its not a blocker, there's other ways around this (I'll just start with a blank private repo and clone gmt after ssh), but I found it funny that the upterm action fails for this specific use case |
…n; revert mac generate_random_password changes
…hanges to generate password function
… True in tests setup_runner; added mytest mark no_mac_workflow for tests that cannot be run in macos github workflows;
Eco-CI Output:
📈 Energy graph:
7.78 ┤ ╭╮ ╭╮
7.18 ┤ ││ ││
6.58 ┤ ││ ││
5.98 ┤ ╭╯│ ╭╮ ││╭╮
5.38 ┤ │ │ ╭─╯╰╮ │╰╯│
4.77 ┤ ╭╮ ╭╮ │ ╰─╮╭───╮ │ ╰╮ │ │
4.17 ┤ ││ ╭──╮╭─╯│ ╭╮ ╭╮ ╭─╮ ╭─╮ │ ╰╯ │ │ ╰─╯ ╰╮ ╭╮ ╭╮╭──╮ ╭╮ ╭─────╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮ ╭╮╭╮ ╭╮ ╭╮ ╭╮╭─╮ ╭
3.57 ┤ ╭╯╰───╮ │ ╰╯ ╰───╯╰────────╯╰──╯ ╰─────────────────────╯ ╰───────────╯ ╰─╯ │ ╭╮╭╯╰──╯╰╯ ╰─╯╰────────────────────────────╯ ╰─────╮ ╭──╯╰─╯╰──╮╭──────────────────╯╰───────╯╰───────────╯╰──╯╰───╯╰──────╮ ╭────────────╯╰╯╰────╯╰───╯╰───╯╰╯ ╰─╮ ╭─╮ ╭╮ ╭╯
2.97 ┤ │ ╰╮ │ │ │╰╯ │ │ ││ ╰╮ │ │ │ ╰╮ ││ │
2.37 ┤ │ │ ╭╯ │ │ ╰╮ ╭╯ ╰╯ │╭╯ │ │ │ ││ │
1.77 ┼────╯ ╰───╯ ╰───────╯ ╰──────────────────╯ ╰╯ ╰────────╯ ╰────────╯╰─╯
Watts over time |
We have tried to get our tests running on the GitHub Mac CI/CD runners. Unfortunately it turns out that this is not that easy to do in a reliable matter. While it is possible to actually get the tests to run there is loads of boiler plate code you need to wrap around the original tests to get things to work sort of defeating the purpose of the tests. A few things that needed fixing are:
/tmp
for some reason so you need to write all the temp data to~
We are pausing this for now as we don't really officially support Mac for runs. We would love some help though. Feel free if this is something you would want to help us doing.