Multiple Makefile fixes: #58
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Manpage compression is a packager/sysadmin task. Forcing .gz compression via Makefile not only creates duplicate work but is also frequently wrong (modern distros use different compressed file formats).
Rather than opaquely making 'install' depend on 'all' (and 'install-bin' fail when called immediately), make 'install-bin' specifically depend on the generated binary file it needs.
'install -D' option is specific to GNU userland, and does not work anywhere else. Use explicit 'install -d' to create files prior to installing them.
|
Non-gnu systems have also problem with bash. The code itself should be posix complaint or work on dash. |
graysky2
force-pushed
the
master
branch
2 times, most recently
from
6242df0
to
4115a1c
Compare
|
Ping. |
graysky2
force-pushed
the
master
branch
3 times, most recently
from
bb1dbd9
to
1eb2a0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
install-bintarget.install(1)usage to be portable to non-GNU systems.