Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(design): update the way the nav height is calculated #2714

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

feat(design): update the way the nav height is calculated #2714

wants to merge 2 commits into from

Conversation

xelaint
Copy link
Member

@xelaint xelaint commented Jan 11, 2024 •
edited
Loading

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Fixes: #3432

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@xelaint xelaint added package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft. labels Jan 12, 2024
@xelaint xelaint added this to the Daffodil v1.0 milestone Jan 12, 2024
@xelaint
Copy link
Member Author

xelaint commented Nov 1, 2024

@damienwebdev can we revisit this? Docs nav needs a slightly different design than the marketing portion of daff.io, and the way nav height is currently calculated causes issues.

@damienwebdev
Copy link
Member

@xelaint sure. Can you post the two intended nav designs here outlining the differences between each?

@xelaint
Copy link
Member Author

xelaint commented Nov 2, 2024 •
edited
Loading

@xelaint sure. Can you post the two intended nav designs here outlining the differences between each?

@damienwebdev Docs nav should have a bottom border like this, but you can see that the sidebar is covering it because --daff-sidebar-side-fixed-top-shift is a fixed value that we set on <body>.

Screen Shot 2024-11-02 at 9 12 04 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@damienwebdev damienwebdev

Labels
package: design @daffodil/design status: wip This PR is WIP. It should be marked as a draft.
Projects
None yet
Milestone
Daffodil v1.0
Development

Successfully merging this pull request may close these issues.

[FEAT] Update the way the nav height is calculated in the sidebar viewport component
2 participants
@xelaint @damienwebdev