Skip to content

feat: yfm plugins parameter #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

feat: yfm plugins parameter #143

merged 1 commit into from
Oct 30, 2023

Conversation

Kyzyl-ool
Copy link
Contributor

No description provided.

@Kyzyl-ool Kyzyl-ool requested a review from NikitaCG as a code owner October 27, 2023 13:52
@gravity-ui-bot
Copy link
Contributor

Preview is ready.

export const transformPost = (
postData: PostData,
lang: Lang,
{plugins}: TransformPostOptions = {},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need use agrument-object when arguments quantity more than 2, but it is breaking change. I suggest after merge of this PR to make edits in #137. can you create issue after merge this PR ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, of course

package.json Outdated
@@ -1,6 +1,6 @@
{
"name": "@gravity-ui/blog-constructor",
"version": "5.7.2",
"version": "5.8.0-alpha.0",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we still need this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nope, used for testing

@Kyzyl-ool Kyzyl-ool merged commit cc971a9 into main Oct 30, 2023
@Kyzyl-ool Kyzyl-ool deleted the feat/yfm-plugins branch October 30, 2023 11:51
@NikitaCG NikitaCG mentioned this pull request Feb 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants