[v17] Improve per-session MFA in a desktop session #52916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Do not try to send an empty MFA challenge in a desktop session * Prevent a runtime error when neither a challenge nor a request is present * Do not overwrite MFA errors with a custom message, show an error when the MFA dialog is closed * Fix a test so that either a request or a challenge is passed * Desktop Access -> Desktop access * Reduce nesting (cherry picked from commit 522bd4e)
zmb3
approved these changes
Mar 10, 2025
marcoandredinis
approved these changes
Mar 10, 2025
public-teleport-github-review-bot
bot
removed the request for review
from Joerger
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #52790 to branch/v17
Clean backport.
changelog: Web UI now properly shows per-session MFA errors in desktop sessions