Web: Add MarkInverse and ResourceLabelTooltip contents #50532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
if it helps to see how it will be used, here is screenshot (ignore the invisible mark, this version was before those changes) 
|
flyinghermit
approved these changes
Dec 23, 2024
| @@ -26,3 +26,8 @@ export const Mark = styled.mark` | |||
| background-color: ${p => p.theme.colors.interactive.tonal.neutral[2]}; | |||
| color: inherit; | |||
| `; | |||
|
|
|||
| export const MarkInverse = styled(Mark)` | |||
There was a problem hiding this comment.
nit: JSdoc on exported function/var/types/styles etc.
| import { IconTooltip } from 'design/Tooltip'; | ||
| import styled from 'styled-components'; | ||
|
|
||
| export function ResourceLabelTooltip({ |
public-teleport-github-review-bot
bot
removed the request for review
from rudream
|
Copy looks good to me! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #46976
This PR
Markto be used insideTooltips, otherwiseMarkis invisible. Tooltips uses inverse background color of main theme (eg: tooltips for dark theme uses light background and vice versa).Screenshots
RDS - dark theme
EKS - dark theme
SERVER - light theme
DATABASE - light theme
KUBE - bblp theme
