Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document disabling default import rule #50324

Merged
merged 5 commits into from
Dec 23, 2024
Merged

Document disabling default import rule #50324

merged 5 commits into from
Dec 23, 2024

Conversation

Tener
Copy link
Contributor

@Tener Tener commented Dec 17, 2024

No description provided.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-9narr46ni-goteleport.vercel.app/docs

@Tener Tener added the no-changelog Indicates that a PR does not require a changelog entry label Dec 17, 2024
greedy52
greedy52 approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@greedy52 greedy52 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should we update this reference too?

https://goteleport.com/docs/reference/resources/#database-object-import-rule

ptgott
ptgott approved these changes Dec 17, 2024
View reviewed changes
docs/pages/enroll-resources/database-access/rbac.mdx Outdated Show resolved Hide resolved
docs/pages/enroll-resources/database-access/rbac.mdx Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-ndki3r7cc-goteleport.vercel.app/docs

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-2bigbt6qt-goteleport.vercel.app/docs

@Tener
Copy link
Contributor Author

Tener commented Dec 18, 2024 •
edited
Loading

should we update this reference too?

https://goteleport.com/docs/reference/resources/#database-object-import-rule

I gave it some thought and I think we are better off not doing that, as there is a risk of confusing readers by mixing "positive" and "negative" use cases in one exmple.

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-7vrq15sh5-goteleport.vercel.app/docs

@Tener
Copy link
Contributor Author

Tener commented Dec 19, 2024

@zmb3 This needs another approval, can you do the honors?

@Tener Tener added this pull request to the merge queue Dec 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 23, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 23, 2024 •
edited
Loading

Amplify deployment status

Branch Commit Job ID Status Preview Updated (UTC)
tener/disable-default-import-rule HEAD 1 ✅SUCCEED tener-disable-default-import-rule 2024-12-23 12:55:36

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-kiiht7kcc-goteleport.vercel.app/docs

@Tener Tener added this pull request to the merge queue Dec 23, 2024
Merged via the queue into master with commit 074d584 Dec 23, 2024
43 checks passed
@Tener Tener deleted the tener/disable-default-import-rule branch December 23, 2024 13:15
@public-teleport-github-review-bot
Copy link

@Tener See the table below for backport results.

Branch Result
branch/v17 Create PR

@Tener Tener mentioned this pull request Dec 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ptgott ptgott ptgott approved these changes

@greedy52 greedy52 greedy52 approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
backport/branch/v17 documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Tener @zmb3 @greedy52 @ptgott