Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak the react-select custom components #47855

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Oct 23, 2024

Fixes #47823

This PR does two things:

  • Fixes the bug where clicking the remove icon on a value causes the dropdown to open (see the attached bug). It does so by delegating common styling and event handling logic to default react-select components instead of attempting to do everything on our own. This also means moving some padding handling from components themselves to the wrapper stylesheet.
  • It tweaks the multi-value pills to make sure that there's equal amount of space around these when the component goes multiline.

select-multi-val-delete

@bl-nero
Copy link
Contributor Author

bl-nero commented Oct 23, 2024

Tested manually by inspecting a random handful of drop-downs throughout the app.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47855.d3pp5qlev8mo18.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React select version update introduced inconsistent deleting behavior
2 participants