Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set default algorithm suite when other auth pref fields are set #47820

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nklaassen
Copy link
Contributor

For new clusters in master and v17 we currently try to set a default cluster_auth_preference.spec.signature_algorithm_suite so that new clusters will use the new signature algorithms. However, we currently only set this default if the teleport.dev/origin label of the cluster_auth_preference is defaults. If the user sets any other field in the teleport.yaml config that ends up being stored in the cluster_auth_preference, the origin label ends up being config-file and the cluster doesn't get the new default signature_algorithm_suite.

This can cause unexpected behaviour - for example, if you don't set up webauthn in teleport.yaml your cluster gets the new algorithms, if you do set up webauthn you are stuck with RSA.

This PR updates the logic to set the default signature_algorithm_suite for new clusters whether or not any other field in the cluster_auth_preference is set in the config file.

@nklaassen nklaassen added the no-changelog Indicates that a PR does not require a changelog entry label Oct 22, 2024
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-47820.d3pp5qlev8mo18.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant