set default algorithm suite when other auth pref fields are set #47820
+91
−71
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For new clusters in master and v17 we currently try to set a default
cluster_auth_preference.spec.signature_algorithm_suite
so that new clusters will use the new signature algorithms. However, we currently only set this default if theteleport.dev/origin
label of thecluster_auth_preference
isdefaults
. If the user sets any other field in the teleport.yaml config that ends up being stored in thecluster_auth_preference
, the origin label ends up beingconfig-file
and the cluster doesn't get the new default signature_algorithm_suite.This can cause unexpected behaviour - for example, if you don't set up webauthn in teleport.yaml your cluster gets the new algorithms, if you do set up webauthn you are stuck with RSA.
This PR updates the logic to set the default
signature_algorithm_suite
for new clusters whether or not any other field in thecluster_auth_preference
is set in the config file.