Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow customized output for make build/{tctl,tsh} #47724

Closed
wants to merge 1 commit into from
Closed

Allow customized output for make build/{tctl,tsh} #47724

wants to merge 1 commit into from

Conversation

codingllama
Copy link
Contributor

Let callers of make build/tsh and make build/tctl customize the output path using the OUT option.

Used by https://github.com/gravitational/teleport.e/pull/5199 to delegate e/Makefile builds to OSS.

@codingllama codingllama added the no-changelog Indicates that a PR does not require a changelog entry label Oct 18, 2024
@codingllama
Copy link
Contributor Author

We might not need this after all. Moving to draft for now.

@codingllama codingllama marked this pull request as draft October 18, 2024 19:34
@codingllama
Copy link
Contributor Author

Yep, this won't be needed. Sorry for the noise.

@codingllama codingllama deleted the codingllama/makefile-out branch October 18, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doggydogworld doggydogworld Awaiting requested review from doggydogworld

@camscale camscale Awaiting requested review from camscale

@kimlisa kimlisa Awaiting requested review from kimlisa

Assignees
No one assigned
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@codingllama