Move vale configs into docs/
#47575
Merged
Move vale configs into docs/
#47575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptgott
force-pushed
the
paul.gottschling/2024-10-15-vale-mv
branch
from
58c3cc5
to
0db6e2a
Compare
|
🤖 Vercel preview here: https://docs-29a7uqg7v-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-dwwbp2m4t-goteleport.vercel.app/docs/ver/preview |
|
🤖 Vercel preview here: https://docs-5tczedhgu-goteleport.vercel.app/docs/ver/preview |
Organize vale prose linter configurations into the `docs` directory so automated workflows treat them as Teleport documentation changes. Otherwise, vale style changes are classified as code changes, which is not correct.
ptgott
force-pushed
the
paul.gottschling/2024-10-15-vale-mv
branch
from
bbe9a07
to
c4d64c4
Compare
|
Here is a run of the vale check with a test page that fails as expected: https://github.com/gravitational/teleport/actions/runs/11351096747/job/31570965899?pr=47575 I removed the test page in this commit. |
ptgott
requested review from
klizhentas,
russjones,
r0mant,
zmb3,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
github-actions
bot
requested review from
fspmarshall,
mmcallister and
xinding33
|
🤖 Vercel preview here: https://docs-h51wgawzy-goteleport.vercel.app/docs/ver/preview |
ptgott
added
the
no-changelog
codingllama
approved these changes
Oct 15, 2024
|
@mmcallister Would you have time to give this a look? Thanks! |
mmcallister
approved these changes
Oct 15, 2024
public-teleport-github-review-bot
bot
removed request for
xinding33 and
fspmarshall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Organize vale prose linter configurations into the
docsdirectory so automated workflows treat them as Teleport documentation changes. Otherwise, vale style changes are classified as code changes, which is not correct.