Remove dead JS code #47574
Merged
Remove dead JS code #47574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzdunek
added
the
no-changelog
zmb3
approved these changes
Oct 16, 2024
ravicious
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
How did you discover that they are unused?
There was a problem hiding this comment.
I accidentally found DocumentTitle. Then I started looking for other files using no-unused-modules eslint rule. I even wondered if we could enable this rule, but well, it would be a looot of work (as always hah).
There was a problem hiding this comment.
I even wondered if we could enable this rule, but well, it would be a looot of work (as always hah).
As in there's a lot of other exports that are unused?
There was a problem hiding this comment.
Yeah, there were over 360 errors.
public-teleport-github-review-bot
bot
removed request for
kimlisa and
rudream
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
mvbrock
pushed a commit
that referenced
this pull request
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few unused components/hooks.