Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve readability of links in the navigation footer tooltip #47534

Merged
merged 3 commits into from
Oct 16, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Oct 12, 2024

Before:

Screenshot 2024-10-12 at 09 28 20

After:

Screenshot 2024-10-12 at 09 26 05 Screenshot 2024-10-12 at 09 26 17

Still not perfect, but the best I can do with this palette.

@bl-nero bl-nero requested a review from rudream October 12, 2024 07:31
@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Oct 12, 2024
@bl-nero
Copy link
Contributor Author

bl-nero commented Oct 12, 2024

@rishibarbhaya-design Also highlighting the issue to you; if there's a better way to highlight the link there, let me know.

Usability note: the tooltip is sticky, requiring a click to dismiss, so users will be able to click the link before it disappears.

@bl-nero bl-nero added this pull request to the merge queue Oct 16, 2024
Merged via the queue into master with commit 23d59d1 Oct 16, 2024
39 checks passed
@bl-nero bl-nero deleted the bl-nero/tooltip-link branch October 16, 2024 06:54
mvbrock pushed a commit that referenced this pull request Oct 16, 2024
* Improve readability of links in the navigation footer tooltip

* Make the linter happy
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants