Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v16] Reorganize the color palette #47504

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

bl-nero
Copy link
Contributor

@bl-nero bl-nero commented Oct 11, 2024

Backport #43304 and #47458 to v16. A word of explanation is needed to understand what happened here: the first PR added a solid colors palette and reorganized it a bit, introducing a lot of small changes throughout the codebase. It then turned out to be unnecessary, so that second PR removed the parts that actually reorganized stuff.

Therefore, it's recommended to review the entire PR at once instead of commit by commit. The final amount of changes is small compared with the two commits separately.

bl-nero and others added 2 commits October 11, 2024 15:52
* Reorganize the color palette

* Update web/packages/design/src/theme/themeColors.story.tsx

Co-authored-by: Rafał Cieślak <[email protected]>

* review

---------

Co-authored-by: Rafał Cieślak <[email protected]>
* wip

* wip

* Remove the background field

* Remove the type

* Post-merge fix
@bl-nero bl-nero marked this pull request as ready for review October 11, 2024 16:51
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@bl-nero bl-nero added the no-changelog Indicates that a PR does not require a changelog entry label Oct 11, 2024
@bl-nero bl-nero added this pull request to the merge queue Oct 18, 2024
Merged via the queue into branch/v16 with commit 28d2262 Oct 18, 2024
45 of 46 checks passed
@bl-nero bl-nero deleted the bl-nero/backport-colors-branch/v16 branch October 18, 2024 06:54
@public-teleport-github-review-bot

@bl-nero See the table below for backport results.

Branch Result
branch/v15 Failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 backport no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants