Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UserTask audit events #47496

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Conversation

marcoandredinis
Copy link
Contributor

Demo:
image

@marcoandredinis marcoandredinis added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Oct 11, 2024
@github-actions github-actions bot added the audit-log Issues related to Teleports Audit Log label Oct 11, 2024
@github-actions github-actions bot requested a review from kiosion October 11, 2024 15:23
@marcoandredinis marcoandredinis force-pushed the marco/emit_usertask_state_prehog_event branch from b3f4082 to 928a175 Compare October 14, 2024 10:24
@marcoandredinis marcoandredinis force-pushed the marco/emit_usertask_state_prehog_event branch from 928a175 to 57862c4 Compare October 15, 2024 15:11
Base automatically changed from marco/emit_usertask_state_prehog_event to master October 15, 2024 15:48
@marcoandredinis
Copy link
Contributor Author

@kiosion @ravicious Can you please take a look when you get a chance?

Copy link
Member

@ravicious ravicious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding those new events to https://github.com/gravitational/teleport/blob/master/web/packages/teleport/src/Audit/fixtures/index.ts?

@marcoandredinis marcoandredinis force-pushed the marco/userttasks_audit_events branch 3 times, most recently from b2cce7a to 41a2e13 Compare October 17, 2024 14:20
Copy link
Contributor

@kiosion kiosion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 18, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 18, 2024
@marcoandredinis marcoandredinis added this pull request to the merge queue Oct 18, 2024
Merged via the queue into master with commit 0e2c948 Oct 18, 2024
44 checks passed
@marcoandredinis marcoandredinis deleted the marco/userttasks_audit_events branch October 18, 2024 09:53
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v16 Failed

marcoandredinis added a commit that referenced this pull request Oct 18, 2024
* Add UserTask audit events

* add events to fixtures
marcoandredinis added a commit that referenced this pull request Oct 18, 2024
* Add UserTask audit events

* add events to fixtures
marcoandredinis added a commit that referenced this pull request Oct 21, 2024
* Add UserTask audit events

* add events to fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit-log Issues related to Teleports Audit Log backport/branch/v16 no-changelog Indicates that a PR does not require a changelog entry size/md ui
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants