fix: use matching signing region for IAM join method #47425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nklaassen
added
the
no-changelog
Joerger
approved these changes
Oct 11, 2024
kimlisa
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47044 was flawed and overrides the target STS endpoint without overriding the signing region used when signing the request. This causes IAM joining to fail with errors like the following whenever the region is set from the IMDSv2 or overridden in a non-FIPS region
This PR fixes the issue by setting the region on the base aws.Config instead of handling region logic in the custom endpoint resolver. The custom endpoint resolver lives on only because it is the simplest way to set the challenge header and the Accept: application/json header, it doesn't actually override the target endpoint.