Implement API and backend for DynamicWindowsDesktop #46987
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probakowski
added
desktop-access
no-changelog
…r-resources-proto
…register-resources-api
…r-resources-proto
…register-resources-api
probakowski
requested review from
klizhentas,
russjones,
r0mant,
fheinecke,
camscale,
tcsc,
rosstimothy and
codingllama
as code owners
…register-resources-config
|
@probakowski - this PR will require admin approval to merge due to its size. Consider breaking it up into a series smaller changes. |
…register-resources-config
…register-resources-api
rosstimothy
reviewed
Oct 17, 2024
rosstimothy
reviewed
Oct 18, 2024
zmb3
approved these changes
Oct 18, 2024
| dynamicWindows, err := dynamicwindowsv1.NewService(dynamicwindowsv1.ServiceConfig{ | ||
| Authorizer: cfg.Authorizer, | ||
| Backend: cfg.AuthServer.Services, | ||
| // TODO(probakowski): switch to cache when support is added |
There was a problem hiding this comment.
Is this TODO still relevant?
There was a problem hiding this comment.
Yes, it will go away in #46989
tigrato
approved these changes
Oct 22, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
* Add DynamicWindowsDesktop to proto * Add resource matchers to Windows desktop service config * Implement API and backend for DynamicWindowsDesktop * Fix imports * move rpc to separate server * rework api and grpc more towards 153-style * e * remove dynamic windows from paginated resource * add tests * add tests * Update api/proto/teleport/legacy/types/types.proto Co-authored-by: rosstimothy <[email protected]> * lint * gci * cleanup * cleanup * use generic service * cleanup * cleanup * cleanup * cleanup * cleanup * gci * add admin action checks * move service * add service test * gci * review comments * review comments * review comments * review comments * review comments --------- Co-authored-by: rosstimothy <[email protected]>
public-teleport-github-review-bot
bot
removed the request for review
from eriktate
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements backend for DynamicWindowsDesktop as well as GRPC calls to manage it.
This is part of splitting #46738 into smaller, easier to review, PRs