Web: Update okta types and add back okta "view status" and row click handler #46261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
added
no-changelog
avatus
approved these changes
Sep 4, 2024
ravicious
approved these changes
Sep 5, 2024
Comment on lines
+37
to
+42
| * Generics: | ||
| * T is resource type "integration" or "plugin" | ||
| * K is the kind of integration (eg: aws-oidc) or plugin (eg: okta) | ||
| * SP is the provider-specific spec of integration or plugin | ||
| * SD is the provider-specific status containing status details | ||
| * - currently only defined for plugin resource |
There was a problem hiding this comment.
Nit, but you can rename generics to ResourceType, IntegrationKind, etc., they don't have to be single or two letter names. 😏
This reverts commit 714c174.
kimlisa
force-pushed
the
lisa/okta-status-related
branch
from
49e456e
to
00887f8
Compare
kimlisa
force-pushed
the
lisa/okta-status-related
branch
from
00887f8
to
82ce3ff
Compare
avatus
approved these changes
Sep 10, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
kimlisa
added a commit
that referenced
this pull request
Sep 10, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
kimlisa
added a commit
that referenced
this pull request
Sep 12, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
kimlisa
added a commit
that referenced
this pull request
Sep 13, 2024
…handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Web: Add support for client search query params for Table (have to opt in) (#46092) * Add flex basis prop to HoverTooltip * Change encodeUrlQueryParams props to object prop * Add client searching query param support to UserList * Move form submission handler closer to InputSearch Also got rid of showSearchBar, it was always set to true * Update test and minor fixes * Fix story * Address CRs * Fix test * Web: Update okta types and add back okta "view status" and row click handler (#46261) * Okta types update * Revert "Remove okta row click handler (not fully implemented) (#46179)" This reverts commit 714c174. * Revert "Remove view status button for okta (not fully implemented) (#46174)" This reverts commit 54a0293. * Require exact route and revert primary route link and text for oidc finish dialog * Web: fix document node searching (#46506) * Delete unused nodes files * Move search panel out of unified to teleport/src/component The search panel in unified dir wasn't that much different from the one already existing in teleport/src/component other than the latter one displayed a page indicator. DocumentNodes and other places now use the same kind of server side search panel. * Get rid of input search auto focus The auto focus can steal focus from other elements * Fix stories and snaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🛑 do not merge until the following is ready to merge or merged:
reverts #46179 and #46174