Move external backend key logic to receiver methods of backend.Key #45985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport/branch/v14
no-changelog
rosstimothy
force-pushed
the
tross/backend-key-implementation
branch
from
4c2e208
to
0eb8349
Compare
fspmarshall
approved these changes
Aug 29, 2024
probakowski
approved these changes
Aug 29, 2024
public-teleport-github-review-bot
bot
removed the request for review
from atburke
rosstimothy
force-pushed
the
tross/backend-key-implementation
branch
2 times, most recently
from
a52f2d3
to
775cc24
Compare
There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the `bytes` package. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.
rosstimothy
force-pushed
the
tross/backend-key-implementation
branch
from
775cc24
to
9b62038
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
@rosstimothy See the table below for backport results.
|
rosstimothy
added a commit
that referenced
this pull request
Sep 3, 2024
…45985) There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the `bytes` package. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.
rosstimothy
added a commit
that referenced
this pull request
Sep 3, 2024
…45985) There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the `bytes` package. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.
rosstimothy
added a commit
that referenced
this pull request
Sep 4, 2024
…45985) There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the `bytes` package. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.
rosstimothy
added a commit
that referenced
this pull request
Sep 4, 2024
…45985) There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the `bytes` package. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of places that the backend.Key is assumed to be a []byte and is passed to various functions from the
bytespackage. This creates equivalent functionality on the backend.Key type so that all assumptions about the backend key type can be removed.Companion: https://github.com/gravitational/teleport.e/pull/4952