Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiscoveryConfigStatus AWS EC2 resource counters (proto) #45553

Merged

Conversation

marcoandredinis
Copy link
Contributor

@marcoandredinis marcoandredinis commented Aug 16, 2024

This PR adds counters for AWS Instances found/enrolled/failed for a given DiscoveryConfig and Integration.

Context: #41909

@marcoandredinis marcoandredinis added discover Issues related to Teleport Discover no-changelog Indicates that a PR does not require a changelog entry backport/branch/v16 labels Aug 16, 2024
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from a1571f3 to fc2499b Compare August 20, 2024 10:19
@marcoandredinis marcoandredinis changed the title Add DiscoveryConfigStatus AWS resource counters (proto) Add DiscoveryConfigStatus AWS EC2 instance counters counters (proto) Aug 20, 2024
@marcoandredinis marcoandredinis changed the title Add DiscoveryConfigStatus AWS EC2 instance counters counters (proto) Add DiscoveryConfigStatus AWS EC2 resource counters (proto) Aug 20, 2024
@marcoandredinis marcoandredinis marked this pull request as ready for review August 20, 2024 13:27
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from fc2499b to 630f4a4 Compare August 20, 2024 13:32
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch 2 times, most recently from fb7668a to 2905c17 Compare August 23, 2024 09:24
@marcoandredinis
Copy link
Contributor Author

Friendly ping @kiosion @timothyb89

This PR adds counters for AWS Instances found/enrolled/failed for a
given DiscoveryConfig and Integration.
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch 2 times, most recently from 48618e2 to 4c93489 Compare August 27, 2024 09:51
@marcoandredinis marcoandredinis force-pushed the marco/discoveryconfigstatus_aws_counters_proto branch from 4c93489 to 0495278 Compare August 27, 2024 09:59
@marcoandredinis marcoandredinis added this pull request to the merge queue Aug 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 27, 2024
@marcoandredinis marcoandredinis added this pull request to the merge queue Aug 27, 2024
Merged via the queue into master with commit 20cf805 Aug 27, 2024
42 checks passed
@marcoandredinis marcoandredinis deleted the marco/discoveryconfigstatus_aws_counters_proto branch August 27, 2024 13:39
@public-teleport-github-review-bot

@marcoandredinis See the table below for backport results.

Branch Result
branch/v16 Failed

marcoandredinis added a commit that referenced this pull request Aug 27, 2024
* Add DiscoveryConfigStatus AWS EC2 resource counters (proto)

This PR adds counters for AWS Instances found/enrolled/failed for a
given DiscoveryConfig and Integration.

* use a map to index on the integration name
github-merge-queue bot pushed a commit that referenced this pull request Aug 27, 2024
…45903)

* Add DiscoveryConfigStatus AWS EC2 resource counters (proto)

This PR adds counters for AWS Instances found/enrolled/failed for a
given DiscoveryConfig and Integration.

* use a map to index on the integration name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v16 discover Issues related to Teleport Discover no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants