Skip to content

Commit

Permalink
kube: expose cluster domain to statefulset pod (#46144) (#46150)
Browse files Browse the repository at this point in the history
This PR corrects a typo that didn't exposed the cluster domain in the statefulset, when it was introduced in PR #43584.

Changelog: Extend Teleport ability to use non-default cluster domains in Kubernetes, avoiding the assumption of `cluster.local`.

Signed-off-by: Tiago Silva <[email protected]>
  • Loading branch information
tigrato authored Sep 3, 2024
1 parent f1f97f2 commit 685b13e
Show file tree
Hide file tree
Showing 2 changed files with 72 additions and 0 deletions.
4 changes: 4 additions & 0 deletions examples/chart/teleport-kube-agent/templates/statefulset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -151,6 +151,10 @@ spec:
- name: TELEPORT_EXT_UPGRADER_VERSION
value: {{ include "teleport-kube-agent.version" . }}
{{- end }}
{{- if .Values.clusterDomain }}
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: {{ .Values.clusterDomain | quote }}
{{- end }}
{{- if .Values.tls.existingCASecretName }}
- name: SSL_CERT_FILE
value: /etc/teleport-tls-ca/ca.pem
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@ sets Pod annotations when specified:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -86,6 +88,8 @@ sets Pod labels when specified:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -180,6 +184,8 @@ sets StatefulSet labels when specified:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -282,6 +288,8 @@ should add insecureSkipProxyTLSVerify to args when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -352,6 +360,8 @@ should add volumeClaimTemplate for data volume when using StatefulSet and action
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -442,6 +452,8 @@ should add volumeClaimTemplate for data volume when using StatefulSet and is Fre
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -522,6 +534,8 @@ should add volumeMount for data volume when using StatefulSet:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -592,6 +606,8 @@ should expose diag port:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -662,6 +678,8 @@ should generate Statefulset when storage is disabled and mode is a Upgrade:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -746,6 +764,8 @@ should have multiple replicas when replicaCount is set (using .replicaCount, dep
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -828,6 +848,8 @@ should have multiple replicas when replicaCount is set (using highAvailability.r
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -898,6 +920,8 @@ should have one replica when replicaCount is not set:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -968,6 +992,8 @@ should install Statefulset when storage is disabled and mode is a Fresh Install:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1040,6 +1066,8 @@ should mount extraVolumes and extraVolumeMounts:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1115,6 +1143,8 @@ should mount jamfCredentialsSecret if it already exists and when role is jamf:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1193,6 +1223,8 @@ should mount jamfCredentialsSecret.name when role is jamf:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1271,6 +1303,8 @@ should mount tls.existingCASecretName and set environment when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
- name: SSL_CERT_FILE
value: /etc/teleport-tls-ca/ca.pem
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
Expand Down Expand Up @@ -1351,6 +1385,8 @@ should mount tls.existingCASecretName and set extra environment when set in valu
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
- name: SSL_CERT_FILE
value: /etc/teleport-tls-ca/ca.pem
- name: HTTPS_PROXY
Expand Down Expand Up @@ -1433,6 +1469,8 @@ should not add emptyDir for data when using StatefulSet:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1503,6 +1541,8 @@ should provision initContainer correctly when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1631,6 +1671,8 @@ should set affinity when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1701,6 +1743,8 @@ should set default serviceAccountName when not set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1782,6 +1826,8 @@ should set environment when extraEnv set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
- name: HTTPS_PROXY
value: http://username:[email protected]:3128
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
Expand Down Expand Up @@ -1854,6 +1900,8 @@ should set image and tag correctly:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:12.2.1
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -1924,6 +1972,8 @@ should set imagePullPolicy when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: Always
livenessProbe:
Expand Down Expand Up @@ -1994,6 +2044,8 @@ should set nodeSelector if set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2078,6 +2130,8 @@ should set preferred affinity when more than one replica is used:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2148,6 +2202,8 @@ should set probeTimeoutSeconds when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2228,6 +2284,8 @@ should set required affinity when highAvailability.requireAntiAffinity is set:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2298,6 +2356,8 @@ should set resources when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2375,6 +2435,8 @@ should set serviceAccountName when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2445,6 +2507,8 @@ should set storage.requests when set in values and action is an Upgrade:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2515,6 +2579,8 @@ should set storage.storageClassName when set in values and action is an Upgrade:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down Expand Up @@ -2585,6 +2651,8 @@ should set tolerations when set in values:
fieldPath: metadata.namespace
- name: RELEASE_NAME
value: RELEASE-NAME
- name: TELEPORT_KUBE_CLUSTER_DOMAIN
value: cluster.local
image: public.ecr.aws/gravitational/teleport-distroless:16.2.0
imagePullPolicy: IfNotPresent
livenessProbe:
Expand Down

0 comments on commit 685b13e

Please sign in to comment.