Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tooling release issues #292

Merged
merged 9 commits into from
Nov 12, 2024
Merged

Fix tooling release issues #292

Changes from 2 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
983caa9
Fix tooling release issues
fheinecke Nov 12, 2024
5baf10c
Add missing token env var
fheinecke Nov 12, 2024
ca91609
typo fix
fheinecke Nov 12, 2024
fe70a4c
Fail release early if tag != makefile version
fheinecke Nov 12, 2024
723ac67
dir fix
fheinecke Nov 12, 2024
cae06a6
fd fix
fheinecke Nov 12, 2024
fa67c40
better error handling
fheinecke Nov 12, 2024
26252d6
set tag for testing
fheinecke Nov 12, 2024
8889a8a
RM tag changes
fheinecke Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions .github/workflows/reusable-cd.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ on:
jobs:
release:
name: Release
runs-on: ubuntu-latest
runs-on: ubuntu-22.04-8core
permissions:
contents: write # Needed to create the release
packages: write # Needed to upload the images to GHCR
Expand All @@ -31,14 +31,15 @@ jobs:
# and get the version based off of that
if [[ "${GITHUB_REF}" =~ refs/tags/.* ]]; then
# Transforms tag refs like refs/tags/tools/${TOOL_NAME}/v1.2.3 into v1.2.3
echo "version=${GITHUB_REF#refs/tags/tools/${TOOL_NAME}}" >> "${GITHUB_OUTPUT}"
VERSION="${GITHUB_REF#refs/tags/tools/${TOOL_NAME}/}"
echo "version=${VERSION}" >> "${GITHUB_OUTPUT}"

# Eventually the parse-version action from the teleport.e repo
# should move into this repo and replace this logic
echo "should-release=true" >> "${GITHUB_OUTPUT}"

# Any '-' character means in a tag ref means that it is a prerelease
if [[ "${GITHUB_REF}" == *-* ]]; then
# Any '-' character means in the version means that it is a prerelease
if [[ "${VERSION}" == *-* ]]; then
echo "is-prerelease=true" >> "${GITHUB_OUTPUT}"
fi
fi
Expand Down Expand Up @@ -117,6 +118,7 @@ jobs:
env:
VERSION: ${{ steps.setup.outputs.version }}
IS_PRERELEASE: ${{ steps.setup.outputs.is-prerelease }}
GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
if [[ "${IS_PRERELEASE}" == 'true' ]]; then
EXTRA_FLAGS=("--prerelease")
Expand Down
Loading