Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix installation instructions #45

Closed
wants to merge 1 commit into from
Closed

Fix installation instructions #45

wants to merge 1 commit into from

Conversation

kopiczko
Copy link

@kopiczko kopiczko commented Nov 20, 2024 •
edited
Loading 

$ go install github.com/gravitational/protoc-gen-terraform       
no required module provides package github.com/gravitational/protoc-gen-terraform; to add it:
        go get github.com/gravitational/protoc-gen-terraform

@kopiczko kopiczko mentioned this pull request Nov 20, 2024
Merged
rosstimothy
rosstimothy reviewed Nov 20, 2024
View reviewed changes
README.md
@@ -7,7 +7,7 @@ protoc plugin to generate Terraform Framework schema definitions and getter/sett
Install the generator binary.

```
go install github.com/gravitational/protoc-gen-terraform
go install github.com/gravitational/protoc-gen-terraform@latest
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is latest fine? Should we recommend a specific version instead?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It surely works. This repository doesn't have any release AFAICT.

Copy link
Contributor

@hugoShaka hugoShaka Nov 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The plugin is versioned, there are no tags though.

The latest version should not be used on Teleport, installation instructions are currently specifying a custom tag: https://github.com/gravitational/teleport/blob/master/integrations/terraform/README.md?plain=1#L12

This repository doesn't have any release AFAICT.

Then we should fix this instead and create tags matching the VERSION file: https://github.com/gravitational/protoc-gen-terraform/blob/main/VERSION

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opened #46

@kopiczko
Copy link
Author

Closing in favour of #46

@kopiczko kopiczko closed this Nov 20, 2024
@kopiczko kopiczko deleted the fix-installation-instructions branch November 20, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rosstimothy rosstimothy rosstimothy left review comments

@hugoShaka hugoShaka hugoShaka left review comments

@marcoandredinis marcoandredinis marcoandredinis approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

@r0mant r0mant Awaiting requested review from r0mant r0mant is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kopiczko @marcoandredinis @hugoShaka @rosstimothy