This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Improve testability of notifications #4515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- wait for a specific notification message - test multiple notifications in one test case
chadwhitacre
force-pushed
the
notification-testability
branch
from
b5f4286 to
f1b42b3
Compare
|
Ready, @rohitpaulk! |
13 tasks
Picks up a bugfix related to the filter css function.
Upgrade libsass from 0.3.0 to 0.12.3
rohitpaulk
reviewed
Jun 14, 2017
js/gratipay/notification.js
Outdated
|
|
||
| var dialog = ['div', { 'class': 'notification notification-' + type }, [ 'div', text ]]; | ||
| var id = Math.random().toString(36).substring(2, 100); | ||
| var placeholder = ['div', {'class': 'notification notification-' + type}, ['div', text]]; |
There was a problem hiding this comment.
Hmm, struggling to understand what's going on here...
There was a problem hiding this comment.
Yeah, I had to unravel this while working here. Better with a9caa08?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Factored out of #4488.