Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

implement UI for working with national identities #4008

Closed
wants to merge 14 commits into from
Closed

implement UI for working with national identities #4008

wants to merge 14 commits into from

Conversation

chadwhitacre
Copy link
Contributor

@chadwhitacre chadwhitacre commented May 4, 2016 •
edited
Loading

⬑ #3994

← #4007 — #4009 →

Punchlist

  • remake against master once show verified identities on profile with flags #4007 lands
  • saving a verified identity should also be in the danger zone since it resets verification
  • consider preventing even admins from seeing identity info
  • write a test suite for %countries.spt
    • I just noticed a test failure here already.

@chadwhitacre chadwhitacre added this to the Bring Back Payroll for Team Gratipay milestone May 4, 2016
This was referenced May 4, 2016
Closed
Merged
@chadwhitacre chadwhitacre changed the title start hacking on identity form implement UI for working with national identities May 4, 2016
@chadwhitacre chadwhitacre mentioned this pull request May 4, 2016
Closed
3 tasks
@chadwhitacre
Copy link
Contributor Author

aff5bdd:

screen shot 2016-05-09 at 12 24 09 pm
screen shot 2016-05-09 at 12 25 59 pm
screen shot 2016-05-09 at 12 25 27 pm
screen shot 2016-05-09 at 12 25 42 pm

@chadwhitacre
Copy link
Contributor Author

☺️

screen shot 2016-05-09 at 3 58 51 pm

@chadwhitacre
Copy link
Contributor Author

chadwhitacre commented May 9, 2016 •
edited
Loading

df2b9b5:

screen shot 2016-05-09 at 4 12 02 pm

screen shot 2016-05-09 at 4 12 10 pm

@chadwhitacre
Copy link
Contributor Author

c45687a:

screen shot 2016-05-09 at 4 37 04 pm

@chadwhitacre
Copy link
Contributor Author

f50c3f9:

screen shot 2016-05-09 at 5 25 56 pm

@chadwhitacre
Copy link
Contributor Author

My thinking is that on the /identities/ page where we have the list of identity cards, the "Add Identity" card/button will pop up a country chooser, and then clicking on the country will take you to /identities/XX where XX is a two-letter country code for a country we know about. That'll be where you can add, edit, and remove identity information.

@chadwhitacre
Copy link
Contributor Author

Chooser into form in 506993d:

77ku2ostmh

@chadwhitacre
Copy link
Contributor Author

👍

c483a6b:

hm0i8ueoaw

@chadwhitacre
Copy link
Contributor Author

Alright, this one is far enough along for now.

@chadwhitacre
Copy link
Contributor Author

I kinda like the cardy things. (I got them from PayPal, as I believe I mentioned somewhere.) We should use them for payment routes methods and maybe accounts elsewhere, too.

@chadwhitacre chadwhitacre mentioned this pull request May 10, 2016
Closed
3 tasks
@rohitpaulk
Copy link
Contributor

I kinda like the cardy things.

Yh, uphold has them too

@chadwhitacre chadwhitacre force-pushed the identity-form branch 2 times, most recently from 25d0844 to 31bdb10 Compare May 11, 2016 10:37
@chadwhitacre
Copy link
Contributor Author

Alright, this one's gonna need a little attention first ...

This was referenced May 11, 2016
Merged
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Bring Back Take-What-You-Want for Tea...
Development

Successfully merging this pull request may close these issues.
2 participants
@chadwhitacre @rohitpaulk