Show dues in team pages

[rorepo]

Changes to show due values, if any, on the teams list and individual team pages.

The value shown is from a new column due in table teams, updated with the summary of values from table payment_instructions.

[chadwhitacre]

CODE!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! 😍

[chadwhitacre]

@rorepo Did you forget to commit branch.sql?

[rorepo]

Oops! Done now :)

[chadwhitacre]

!m @rorepo

[chadwhitacre]

This PR inspired #3862. :-)

[chadwhitacre]

I assume this is ready for review, ya?

[chadwhitacre]

A few things:

• Let's show ndue along with due. Looks goofy to have that cell blank.
• On the Team page, let's show "Due" always, even if it's zero, as we do for the other values.
• Do we need to backfill due? It's zero for everyone. Should it be?

[chadwhitacre]

Also:

• Let's tweak the vertical whitespace on the homepage tables so it fits better now that it has three lines.

[rorepo]

Not sure about the backfill bit, but a thought here - this column is now being populated in participant _update_due, called within set_payment_instruction - perhaps it would be a good idea to include this in the payday run as well.

Made all the other changes suggested.

[rohitpaulk]

I'm 👎 on this. 'Dues' is not a value that we should be displaying across the leaderboard/general UI. I think it only makes sense to expose this on team specific pages (the receiving/history page, in particular).

The cached value for 'receiving' and 'nreceiving_from' already factors in the 'dues' component.

[chadwhitacre]

'Dues' is not a value that we should be displaying across the leaderboard/general UI.

Fair point. The number we really want to show on the leaderboards is sharing, but that's a long way off.

You okay to close this, @rorepo? Or do you want to make a case for displaying "due" in this way instead of the proposal on #3873?

[rorepo]

Happy to defer to the old-timers :-)

Will close this. I take it I then delete the branch as well?