This repository has been archived by the owner on Feb 8, 2018. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is for a preliminary review - have a few issues and questions.
Got things working with my credentials, with
tests/local.env
and after adding the custom field participant_id in settings. 'Working' only in the sense that I getsuccess
andauthorized
, though. When I tried checking on the dashboard, things are less clear - all transactions are shown as 'sale' and some say 'voided', 'submitted for settlement', 'gateway rejected', etc.The transaction summary page shows credit values as 0.
I've got the functionality worked out, but am facing the following issues:
test_refund_of_excess_balance
that I added totest_billing_payday.py
works as expected, but not along with the existing methodtest_payday_preserves_due_until_charged
. If both methods run, the credit part oftest_refund_of_excess_balance
fails with an authorisation error. I see a small possibility that this behaviour may be something to do with my local environment.tests/local.env
. I get 'success' and 'authorized' responses. However, things do not look ok when checking on the Braintree dashboard - credit in the transaction summary is always 0.In addition, I have the following questions:
balances > 0
to do refunds. I believe I will need to apply some other conditions e.g. to exclude 1.0 balances?