Skip to content
This repository has been archived by the owner on Feb 8, 2018. It is now read-only.

Reduce schema.sql #2673

Merged
merged 4 commits into from
Aug 25, 2014
Merged

Reduce schema.sql #2673

merged 4 commits into from
Aug 25, 2014

Conversation

Changaco
Copy link
Contributor

First step of #2360, and #1549.

@seanlinsley
Copy link
Contributor

Did you perform this change manually? Perhaps schema.sql should be automatically generated from a schema dump from the database.

@Changaco
Copy link
Contributor Author

Yes, I did it manually, the output of pg_dump -sO was unsatisfactory.

@seanlinsley
Copy link
Contributor

Surely manual updates will become unmaintainable going forward. Perhaps there's a tool we can use to generate good-looking schema dumps?

It wasn't in schema.sql but we have it on the production DB.
@Changaco
Copy link
Contributor Author

I diffed the results of pg_dump -sO on a backup of the production DB and on my local test DB created with the new schema (using make test-schema). Found a few mistakes and a missing index.

@Changaco
Copy link
Contributor Author

Okay, the build is fixed, this is ready for merge. There is little risk in merging since schema.sql is obviously never run on the production DB.

@Changaco
Copy link
Contributor Author

Merging so that I can move forward with PRs that have a branch.sql without risking conflicts.

Changaco added a commit that referenced this pull request Aug 25, 2014
@Changaco Changaco merged commit 8e8e699 into master Aug 25, 2014
@Changaco Changaco deleted the reduce-db-schema branch August 25, 2014 16:40
chadwhitacre added a commit that referenced this pull request Aug 26, 2014
Changaco added a commit that referenced this pull request Aug 26, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants