-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support directive on variable definition #61
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with changes. But
- Please add the test
- If you submit formatting changes, please make it a separate commit (although I'm not sure it make sense as it actively made code worse in one place I've commented below).
Query | Mutation | Subscription | Field | FragmentDefinition | FragmentSpread | ||
| InlineFragment => true, | ||
|
||
Schema | Scalar | Object | FieldDefinition | ArgumentDefinition | Interface | Union | ||
| Enum | EnumValue | InputObject | InputFieldDefinition | VariableDefinition => false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This made code worse, and hard to compare. The original formatting is not an accident it's done to have it easier to compare.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can use #[rustfmt::skip]
here FWIW
wait there is no CI that runs these tests 🤔 |
Ah, yes, it's because travis stopped working with github at some point. Should setup a github actions instead. But this doesn't mean there are no tests or that we don't care if they are there. |
Closes #60