Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support directive on variable definition #61

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

saihaj
Copy link
Contributor

@saihaj saihaj commented Jan 11, 2022

Closes #60

Copy link
Collaborator

@tailhook tailhook left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with changes. But

  1. Please add the test
  2. If you submit formatting changes, please make it a separate commit (although I'm not sure it make sense as it actively made code worse in one place I've commented below).

Comment on lines +477 to +481
Query | Mutation | Subscription | Field | FragmentDefinition | FragmentSpread
| InlineFragment => true,

Schema | Scalar | Object | FieldDefinition | ArgumentDefinition | Interface | Union
| Enum | EnumValue | InputObject | InputFieldDefinition | VariableDefinition => false,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This made code worse, and hard to compare. The original formatting is not an accident it's done to have it easier to compare.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can use #[rustfmt::skip] here FWIW

@saihaj
Copy link
Contributor Author

saihaj commented Jan 14, 2022

wait there is no CI that runs these tests 🤔

@tailhook
Copy link
Collaborator

Ah, yes, it's because travis stopped working with github at some point. Should setup a github actions instead. But this doesn't mean there are no tests or that we don't care if they are there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

spec: Directives on variable definitions
4 participants