Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dependabot config #461

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

danieleades
Copy link
Contributor

No description provided.

@danieleades
Copy link
Contributor Author

my motivation for adding this is driven by discovering that my projects which use graphql-client end up with multiple versions of a few dependencies. I tracked this down to the fact that this library has a number of out of date dependencies. Dependabot can help keep these up-to-date without additional maintenance burden.

This is also caused somewhat by the slightly strange 'reqwest' feature in this library.

This feature adds a dependency on reqwest, but does not re-export the reqwest client. That forces you to depend on reqwest transitively through this library and directly from your own. This can lead to multiple versions of reqwest (and all of its dependencies).

In addition to adding dependabot config, i'd suggest re-exporting the reqwest client from the reqwest module, or doing a more thorough rework of this part of the library

@danieleades
Copy link
Contributor Author

marking as draft in favour of #465

dependabot should only really be used if an MSRV check is in place to ensure that dependency bumps don't inadvertently bump the toolchain version needed to build the library

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant