Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GraphQLView option to disable CORS headers #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add GraphQLView option to disable CORS headers #6

wants to merge 1 commit into from

Conversation

stropo
Copy link

@stropo stropo commented Aug 21, 2017

Use Sanic-CORS extension instead which is mature and flexible

@stropo
Add GraphQLView option to disable CORS headers
c316ce1 
Use Sanic-CORS extension instead which is mature and flexible
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 99.265% when pulling c316ce1 on stropo:optional-cors-headers into 560f1cd on graphql-python:master.

dpnova
dpnova reviewed Sep 3, 2017
View reviewed changes
Copy link
Contributor

@dpnova dpnova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I got bitten by this issue too.

@tcsavage
Copy link

Any movement on this? I've just hit this issue, would be great to have this.

@sacha-sentier
Copy link

Do you need help? A bit sad to see these pull requests hang here forever…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpnova dpnova dpnova left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@stropo @coveralls @tcsavage @sacha-sentier @dpnova